Update docker compose and README #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaeri
force-pushed
the
docker-comp-update
branch
from
c4d21e5 to
64993a2
Compare
AtomicLiquid
requested changes
Sep 28, 2024
docker/docker-compose.yml
Outdated
| @@ -21,7 +21,7 @@ services: | |||
| - POSTGRES_DB=evosc_sharp | |||
|
|
|||
| evosc_sharp: | |||
| image: evoscsharp:latest | |||
| image: evoesports/evosc-sharp:latest | |||
There was a problem hiding this comment.
This shouldn't be evoesports/evosc-sharp (or atleast not yet). This should be the build of EvoSC-sharp locally, by building the project with docker build -t evoscsharp . from the working directory.
There was a problem hiding this comment.
I see, my apologies, will drop that change
There was a problem hiding this comment.
No problem haha, it's not documented anywhere, so difficult to know!
Update to new trackmania image, and likewise evosc_sharp. Update README to new docker image
flaeri
force-pushed
the
docker-comp-update
branch
from
64993a2 to
14c81cf
Compare
AtomicLiquid
approved these changes
Sep 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to new trackmania image, and likewise evosc_sharp.
Prior to this change, docker compose would fail, as the old trackmania image (deprecated) no longer exists. Same for the previous evosc_sharp.
Old trackmania image (with deprecation note):
https://hub.docker.com/r/evotm/trackmania
Old evosc_sharp:
https://hub.docker.com/r/evoesports/evoscsharp (does not exist)
I have not updated the EvoSC.csproj version number, as I assumed it wont be required for this change.